Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for custom properties for braze purchase events #2856

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

utsabc
Copy link
Member

@utsabc utsabc commented Nov 29, 2023

Description of the change

Adding support for properties fields for Purchase events to Braze ref

Screenshot 2023-11-29 at 6 06 27 PM

The properties field is mapped with all the extra fields perent in each of the product elements present in Order Completed event.

This change introduces additional data to be sent into Braze

Refer to linear ticket INT-1076 for further details

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@utsabc utsabc requested review from a team as code owners November 29, 2023 12:38
Copy link
Contributor

coderabbitai bot commented Nov 29, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@utsabc utsabc requested review from krishna2020, Gauravudia and ItsSudip and removed request for ujjwal-ab and saikumarrs November 29, 2023 12:39
@utsabc utsabc self-assigned this Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3127a1c) 87.17% compared to head (de171b4) 87.19%.
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2856      +/-   ##
===========================================
+ Coverage    87.17%   87.19%   +0.01%     
===========================================
  Files          772      776       +4     
  Lines        28805    28942     +137     
  Branches      6767     6788      +21     
===========================================
+ Hits         25112    25235     +123     
- Misses        3350     3365      +15     
+ Partials       343      342       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ItsSudip
ItsSudip previously approved these changes Dec 1, 2023
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@utsabc utsabc merged commit be6ef26 into develop Dec 6, 2023
16 checks passed
@utsabc utsabc deleted the fix.braze-purchase-properties branch December 6, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants